Issue 664593002: - Add a separate step to finalize the VM isolate explicitly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 664593002: - Add a separate step to finalize the VM isolate explicitly. (Closed)

Created:
6 years, 2 months ago by Ivan Posva

Modified:
6 years, 2 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

- Add a separate step to finalize the VM isolate explicitly. - Allocate the method extractor parameter types and names only once, namely in the VM isolate. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=41173

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -36 lines)			Patch
M	runtime/vm/dart.cc	View	1	3 chunks	+2 lines, -21 lines	0 comments	Download
M	runtime/vm/object.h	View	1	3 chunks	+18 lines, -2 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	7 chunks	+55 lines, -6 lines	0 comments	Download
M	runtime/vm/resolver.cc	View	1	1 chunk	+2 lines, -6 lines	0 comments	Download
M	runtime/vm/symbols.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Ivan Posva

6 years, 2 months ago (2014-10-17 17:02:25 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as r41173 (presubmit successful).