Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 664283004: Revert "Constant fold charCodeAt via constant system" (Closed)

Created:
6 years, 1 month ago by sra1
Modified:
6 years, 1 month ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Constant fold charCodeAt via constant system" TBR=johnniwinther@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41382

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -111 lines) Patch
M sdk/lib/_internal/compiler/implementation/constant_system.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/constant_system_dart.dart View 2 chunks +0 lines, -30 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart View 2 chunks +1 line, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart View 2 chunks +0 lines, -21 lines 0 comments Download
D tests/compiler/dart2js/constant_folding_codeUnitAt_test.dart View 1 chunk +0 lines, -45 lines 0 comments Download
M tests/compiler/dart2js/mock_libraries.dart View 2 chunks +1 line, -1 line 0 comments Download
M tests/language/compile_time_constant_c_test.dart View 1 chunk +2 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sra1
Committed patchset #1 (id:1) manually as 41382 (presubmit successful).
6 years, 1 month ago (2014-10-29 00:47:07 UTC) #1
Johnni Winther
6 years, 1 month ago (2014-10-29 07:43:07 UTC) #2
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698