Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 66303006: Pub shouldn't emit colored log output unless it's to a terminal. (Closed)

Created:
7 years, 1 month ago by nweiz
Modified:
7 years, 1 month ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Pub shouldn't emit colored log output unless it's to a terminal. R=rnystrom@google.com BUG=14195 Committed: https://code.google.com/p/dart/source/detail?r=30167

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M sdk/lib/_internal/pub/lib/src/utils.dart View 1 chunk +10 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
7 years, 1 month ago (2013-11-09 02:55:22 UTC) #1
Bob Nystrom
LGTM!
7 years, 1 month ago (2013-11-11 18:45:33 UTC) #2
nweiz
7 years, 1 month ago (2013-11-11 19:22:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r30167 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698