Issue 66293008: Properly close watcher streams during tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 66293008: Properly close watcher streams during tests. (Closed)

Created:
7 years, 1 month ago by nweiz

Modified:
7 years, 1 month ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Properly close watcher streams during tests. This also makes [futureStream] pass cancellations through to the underlying stream, and adds the ability for it to return broadcast streams. R=rnystrom@google.com BUG=14943 Committed: https://code.google.com/p/dart/source/detail?r=30180

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+115 lines, -32 lines)			Patch
M	pkg/barback/lib/src/utils.dart	View	1 chunk	+39 lines, -10 lines	0 comments	Download
M	pkg/pkg.status	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	pkg/scheduled_test/lib/src/utils.dart	View	1 chunk	+40 lines, -11 lines	0 comments	Download
M	pkg/watcher/lib/src/utils.dart	View	1 chunk	+35 lines, -8 lines	0 comments	Download
M	pkg/watcher/test/utils.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

nweiz

7 years, 1 month ago (2013-11-12 01:42:11 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r30180 (presubmit successful).