Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 662593003: Support dynamic get/invocation in analyzer2dart. (Closed)

Created:
6 years, 2 months ago by Johnni Winther
Modified:
6 years, 2 months ago
Reviewers:
Paul Berry, floitsch
CC:
reviews_dartlang.org, Paul Berry, Kevin Millikin (Google)
Visibility:
Public.

Description

Support dynamic get/invocation in analyzer2dart. BUG= R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=41164

Patch Set 1 #

Patch Set 2 : Rebased #

Total comments: 2

Patch Set 3 : Rebased and updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -24 lines) Patch
M pkg/analyzer2dart/lib/src/cps_generator.dart View 1 5 chunks +36 lines, -10 lines 0 comments Download
M pkg/analyzer2dart/lib/src/semantic_visitor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer2dart/lib/src/tree_shaker.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer2dart/test/end2end_test.dart View 2 chunks +46 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart View 1 2 8 chunks +54 lines, -10 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/use_unused_api.dart View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Johnni Winther
6 years, 2 months ago (2014-10-17 10:37:36 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/662593003/diff/20001/sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart File sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart (right): https://codereview.chromium.org/662593003/diff/20001/sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart#newcode1773 sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart:1773: List<ir.Primitive> arguments = new List<ir.Primitive>(); = node.arguments.mapToList(visit, growable: ...
6 years, 2 months ago (2014-10-17 11:34:48 UTC) #3
Johnni Winther
https://codereview.chromium.org/662593003/diff/20001/sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart File sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart (right): https://codereview.chromium.org/662593003/diff/20001/sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart#newcode1773 sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart:1773: List<ir.Primitive> arguments = new List<ir.Primitive>(); On 2014/10/17 11:34:48, floitsch ...
6 years, 2 months ago (2014-10-17 11:54:30 UTC) #4
Johnni Winther
Committed patchset #3 (id:40001) manually as 41164 (presubmit successful).
6 years, 2 months ago (2014-10-17 11:55:45 UTC) #5
Paul Berry
6 years, 2 months ago (2014-10-17 14:13:43 UTC) #7
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698