Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 662363002: Support if-statements in analyzer2dart. (Closed)

Created:
6 years, 2 months ago by Johnni Winther
Modified:
6 years, 2 months ago
Reviewers:
Paul Berry, sigurdm
CC:
reviews_dartlang.org, Paul Berry
Visibility:
Public.

Description

Support if-statements in analyzer2dart. BUG= R=sigurdm@google.com Committed: https://code.google.com/p/dart/source/detail?r=41186

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -59 lines) Patch
M pkg/analyzer2dart/lib/src/cps_generator.dart View 1 chunk +17 lines, -0 lines 0 comments Download
M pkg/analyzer2dart/test/end2end_test.dart View 1 chunk +51 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart View 1 chunk +69 lines, -0 lines 4 comments Download
M sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder_visitor.dart View 1 chunk +8 lines, -59 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Johnni Winther
6 years, 2 months ago (2014-10-20 08:38:56 UTC) #2
sigurdm
lgtm https://codereview.chromium.org/662363002/diff/1/sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart File sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart (right): https://codereview.chromium.org/662363002/diff/1/sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart#newcode450 sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart:450: /// then and else branches are created throught ...
6 years, 2 months ago (2014-10-20 09:12:03 UTC) #3
Johnni Winther
https://codereview.chromium.org/662363002/diff/1/sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart File sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart (right): https://codereview.chromium.org/662363002/diff/1/sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart#newcode450 sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart:450: /// then and else branches are created throught the ...
6 years, 2 months ago (2014-10-20 10:18:53 UTC) #4
Johnni Winther
Committed patchset #1 (id:1) manually as 41186 (presubmit successful).
6 years, 2 months ago (2014-10-20 10:21:47 UTC) #5
Paul Berry
6 years, 2 months ago (2014-10-20 13:39:29 UTC) #7
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698