Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 662013004: fix duplicate script issue (Closed)

Created:
6 years, 2 months ago by jakemac
Modified:
6 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : add warnings and fix dynamic version #

Total comments: 18

Patch Set 3 : code review updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -10 lines) Patch
M pkg/polymer/lib/src/build/generated/messages.html View 1 2 1 chunk +31 lines, -2 lines 0 comments Download
M pkg/polymer/lib/src/build/import_inliner.dart View 1 2 4 chunks +10 lines, -2 lines 0 comments Download
M pkg/polymer/lib/src/build/messages.dart View 1 2 1 chunk +23 lines, -0 lines 0 comments Download
M pkg/polymer/lib/src/mirror_loader.dart View 1 2 2 chunks +13 lines, -6 lines 0 comments Download
M pkg/polymer/test/build/import_inliner_test.dart View 1 2 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
jakemac
6 years, 2 months ago (2014-10-18 00:26:13 UTC) #2
Siggi Cherem (dart-lang)
looks great. We still need to fix the dynamic version in dartium as well. That ...
6 years, 2 months ago (2014-10-18 00:40:25 UTC) #3
jakemac
On 2014/10/18 00:40:25, Siggi Cherem (dart-lang) wrote: > looks great. We still need to fix ...
6 years, 2 months ago (2014-10-20 16:34:10 UTC) #4
Siggi Cherem (dart-lang)
https://codereview.chromium.org/662013004/diff/20001/pkg/polymer/lib/src/build/generated/messages.html File pkg/polymer/lib/src/build/generated/messages.html (right): https://codereview.chromium.org/662013004/diff/20001/pkg/polymer/lib/src/build/generated/messages.html#newcode127 pkg/polymer/lib/src/build/generated/messages.html:127: <p>These are the rules you must follow to write ...
6 years, 2 months ago (2014-10-21 17:06:03 UTC) #5
jakemac
updated https://codereview.chromium.org/662013004/diff/20001/pkg/polymer/lib/src/build/generated/messages.html File pkg/polymer/lib/src/build/generated/messages.html (right): https://codereview.chromium.org/662013004/diff/20001/pkg/polymer/lib/src/build/generated/messages.html#newcode127 pkg/polymer/lib/src/build/generated/messages.html:127: <p>These are the rules you must follow to ...
6 years, 2 months ago (2014-10-21 18:14:01 UTC) #6
Siggi Cherem (dart-lang)
lgtm
6 years, 2 months ago (2014-10-21 19:34:12 UTC) #7
jakemac
6 years, 2 months ago (2014-10-22 15:33:37 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as 41245 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698