Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 662013002: update protocol server getter test (Closed)

Created:
6 years, 2 months ago by danrubel
Modified:
6 years, 2 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Visibility:
Public.

Description

update protocol server getter test BUG= R=paulberry@google.com Committed: https://code.google.com/p/dart/source/detail?r=41176

Patch Set 1 #

Patch Set 2 : remove unused import #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M pkg/analysis_server/test/protocol_server_test.dart View 3 chunks +4 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/test_support.dart View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
Based upon the name of the test, I updated the protocol test. I'm happy to ...
6 years, 2 months ago (2014-10-17 13:33:14 UTC) #2
Paul Berry
lgtm
6 years, 2 months ago (2014-10-17 14:18:40 UTC) #3
danrubel
6 years, 2 months ago (2014-10-17 17:34:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 41176 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698