Issue 661933002: Split IrBuilder and IrBuilderVisitor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 661933002: Split IrBuilder and IrBuilderVisitor. (Closed)

Created:
6 years, 2 months ago by Johnni Winther

Modified:
6 years, 2 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org, sigurdm, Kevin Millikin (Google)

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Split IrBuilder and IrBuilderVisitor. BUG= R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=41163

Patch Set 2 : #

Total comments: 1

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+369 lines, -308 lines)			Patch
	M	pkg/analyzer2dart/lib/src/cps_generator.dart	View	1	3 chunks	+21 lines, -11 lines	0 comments	Download
	M	sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart	View	1	64 chunks	+348 lines, -297 lines	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Johnni Winther

https://codereview.chromium.org/661933002/diff/20001/sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart File sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart (right): https://codereview.chromium.org/661933002/diff/20001/sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart#newcode528 sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart:528: // Build(BreakStatement L, C) = C[InvokeContinuation(...)] A lot more ...

6 years, 2 months ago (2014-10-17 10:13:46 UTC) #2

Johnni Winther

6 years, 2 months ago (2014-10-17 11:41:32 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 41163 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 661933002: Split IrBuilder and IrBuilderVisitor. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages