Issue 66193010: Way more documentation blanks filled in.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 66193010: Way more documentation blanks filled in. (Closed)

Created:
7 years, 1 month ago by Andrei Mouravski

Modified:
7 years, 1 month ago

Reviewers:
Kathy Walrath, floitsch, blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Way more documentation blanks filled in. Committed: https://code.google.com/p/dart/source/detail?r=30134

Patch Set 1 #

Total comments: 1

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+750 lines, -3 lines)			Patch
M	pkg/unittest/lib/unittest.dart	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	sdk/lib/core/print.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View	12 chunks	+232 lines, -0 lines	1 comment	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	12 chunks	+232 lines, -0 lines	0 comments	Download
M	tools/dom/docs/docs.json	View	9 chunks	+267 lines, -0 lines	0 comments	Download
M	tools/dom/dom.json	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Window.darttemplate	View	2 chunks	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Andrei Mouravski

Committed patchset #1 manually as r30134 (presubmit successful).

7 years, 1 month ago (2013-11-09 01:19:54 UTC) #3

Kathy Walrath

7 years, 1 month ago (2013-11-09 01:52:22 UTC) #4

Message was sent while issue was closed.

Great stuff!

https://codereview.chromium.org/66193010/diff/1/sdk/lib/html/dart2js/html_dar...
File sdk/lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/66193010/diff/1/sdk/lib/html/dart2js/html_dar...
sdk/lib/html/dart2js/html_dart2js.dart:27099: +   * quirksmode.
quirksmode -> QuirksMode or QuirksMode.org

(The About page uses QuirksMode.org, and the <title> elements use QuirksMode.)

Expand Messages | Collapse Messages