Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 661923003: Support binary expressions in analyzer2dart. (Closed)

Created:
6 years, 2 months ago by Johnni Winther
Modified:
6 years, 2 months ago
Reviewers:
Paul Berry, floitsch
CC:
reviews_dartlang.org, sigurdm, Paul Berry
Visibility:
Public.

Description

Support binary expressions in analyzer2dart. BUG= R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=41167

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+466 lines, -225 lines) Patch
M pkg/analyzer2dart/lib/src/cps_generator.dart View 1 chunk +34 lines, -0 lines 0 comments Download
M pkg/analyzer2dart/test/end2end_test.dart View 1 chunk +192 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart View 1 1 chunk +226 lines, -0 lines 1 comment Download
M sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder_visitor.dart View 1 9 chunks +14 lines, -225 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
https://codereview.chromium.org/661923003/diff/20001/sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart File sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart (right): https://codereview.chromium.org/661923003/diff/20001/sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart#newcode498 sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart:498: These are moved/adapted from IrBuilderVisitor.
6 years, 2 months ago (2014-10-17 11:37:40 UTC) #2
floitsch
LGTM.
6 years, 2 months ago (2014-10-17 11:55:25 UTC) #3
Johnni Winther
Committed patchset #2 (id:20001) manually as 41167 (presubmit successful).
6 years, 2 months ago (2014-10-17 12:29:26 UTC) #4
Paul Berry
6 years, 2 months ago (2014-10-17 14:15:44 UTC) #6
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698