IR refactoring: reduce duplication related to MayThrow/AllowsCSE.

IR refactoring: reduce duplication related to MayThrow/AllowsCSE.

Fold those things into TemplateInstruction/TemplateDefinition.

R=fschneider@google.com, zerny@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=41281

[zerny-google, 2014-10-24 13:38:22]

zerny@google.com changed reviewers:
+ zerny@google.com

[zerny-google, 2014-10-24 13:38:22]

lgtm

[Florian Schneider, 2014-10-24 14:35:07]

lgtm

https://codereview.chromium.org/661783003/diff/1/runtime/vm/intermediate_lang...
File runtime/vm/intermediate_language.h (left):

https://codereview.chromium.org/661783003/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language.h:4143: // the array while the external
data-array is still accessed.
This comment still is valid, so maybe preserve it.

https://codereview.chromium.org/661783003/diff/1/runtime/vm/intermediate_lang...
File runtime/vm/intermediate_language.h (right):

https://codereview.chromium.org/661783003/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language.h:903: template<typename DefaultBase, typename
PureBase>
I'd add a comment here what Pure means in this context (i.e. CSE is enabled, no
side-effects/dependencies)

https://codereview.chromium.org/661783003/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language.h:2844: 
Remove extra \n.

[Vyacheslav Egorov (Google), 2014-10-24 14:59:54]

vegorov@google.com changed reviewers:
+ vegorov@google.com

[Vyacheslav Egorov (Google), 2014-10-24 14:59:54]

https://codereview.chromium.org/661783003/diff/1/runtime/vm/intermediate_lang...
File runtime/vm/intermediate_language.h (left):

https://codereview.chromium.org/661783003/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language.h:4143: // the array while the external
data-array is still accessed.
On 2014/10/24 14:35:06, Florian Schneider wrote:
> This comment still is valid, so maybe preserve it.

Done.

https://codereview.chromium.org/661783003/diff/1/runtime/vm/intermediate_lang...
File runtime/vm/intermediate_language.h (right):

https://codereview.chromium.org/661783003/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language.h:903: template<typename DefaultBase, typename
PureBase>
On 2014/10/24 14:35:06, Florian Schneider wrote:
> I'd add a comment here what Pure means in this context (i.e. CSE is enabled,
no
> side-effects/dependencies)

Done.

https://codereview.chromium.org/661783003/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language.h:2844: 
On 2014/10/24 14:35:06, Florian Schneider wrote:
> Remove extra \n.

Done.

[Vyacheslav Egorov (Chromium), 2014-10-24 15:10:19]

Committed patchset #1 (id:1) manually as 41281 (presubmit successful).