Issue 661603003: Revert "Stop suppressing generation of bindings with Promise. Add some tests for DOM APIs that answ…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 661603003: Revert "Stop suppressing generation of bindings with Promise. Add some tests for DOM APIs that answ… (Closed)

Created:
6 years, 2 months ago by rmacnak

Modified:
6 years, 2 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Revert "Stop suppressing generation of bindings with Promise. Add some tests for DOM APIs that answer promises." TBR=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=41138

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -732 lines)			Patch
M	sdk/lib/_blink/dartium/_blink_dartium.dart	View	16 chunks	+6 lines, -92 lines	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View	18 chunks	+0 lines, -244 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	18 chunks	+0 lines, -202 lines	0 comments	Download
D	tests/html/fontface_loaded_test.dart	View	1 chunk	+0 lines, -46 lines	0 comments	Download
M	tests/html/html.status	View	2 chunks	+0 lines, -3 lines	0 comments	Download
D	tests/html/storage_quota_test.dart	View	1 chunk	+0 lines, -37 lines	0 comments	Download
M	tools/dom/dom.json	View	14 chunks	+6 lines, -90 lines	0 comments	Download
M	tools/dom/idl/dart/dart.idl	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/generator.py	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/dom/scripts/htmlrenamer.py	View	4 chunks	+1 line, -17 lines	0 comments	Download

Total messages: 3 (0 generated)

rmacnak

Analyzer unhappy with new tests. Test timing out on Mac and Windows.

6 years, 2 months ago (2014-10-16 02:54:03 UTC) #1

rmacnak

Committed patchset #1 (id:1) manually as 41138 (presubmit successful).

6 years, 2 months ago (2014-10-16 02:54:21 UTC) #2

Message was sent while issue was closed.

lgtm