Support local variables in analyzer2dart.

Support local variables in analyzer2dart.

BUG=
R=floitsch@google.com, paulberry@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41146

[Johnni Winther, 2014-10-16 12:06:45]

johnniwinther@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2014-10-16 12:23:59]

LGTM.

https://codereview.chromium.org/661593004/diff/20001/pkg/analyzer2dart/lib/sr...
File pkg/analyzer2dart/lib/src/semantic_visitor.dart (right):

https://codereview.chromium.org/661593004/diff/20001/pkg/analyzer2dart/lib/sr...
pkg/analyzer2dart/lib/src/semantic_visitor.dart:34: return false;
If that's not just debugging code, I would do it in a separate CL.

https://codereview.chromium.org/661593004/diff/20001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart
(right):

https://codereview.chromium.org/661593004/diff/20001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart:169:
message: "Unknown variable: $element."));
I would indent message to the invariant-args. But ok with how it is.

[Paul Berry, 2014-10-16 12:54:25]

paulberry@google.com changed reviewers:
+ paulberry@google.com

[Paul Berry, 2014-10-16 12:54:26]

lgtm

[Johnni Winther, 2014-10-16 13:01:26]

https://codereview.chromium.org/661593004/diff/20001/pkg/analyzer2dart/lib/sr...
File pkg/analyzer2dart/lib/src/semantic_visitor.dart (right):

https://codereview.chromium.org/661593004/diff/20001/pkg/analyzer2dart/lib/sr...
pkg/analyzer2dart/lib/src/semantic_visitor.dart:34: return false;
On 2014/10/16 12:23:59, floitsch wrote:
> If that's not just debugging code, I would do it in a separate CL.

It is only for debugging.

https://codereview.chromium.org/661593004/diff/20001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart
(right):

https://codereview.chromium.org/661593004/diff/20001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart:169:
message: "Unknown variable: $element."));
On 2014/10/16 12:23:59, floitsch wrote:
> I would indent message to the invariant-args. But ok with how it is.

Done.

[Johnni Winther, 2014-10-16 13:09:41]

Committed patchset #3 (id:40001) manually as 41146 (presubmit successful).