Terminate browsers in sequence.

Terminate browsers in sequence.

Also make iframe larger.

R=whesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41189

[ahe, 2014-10-16 16:00:52]

ahe@google.com changed reviewers:
+ ricow@google.com

[ahe, 2014-10-16 16:00:52]

Killing 8 processes in fast succession confuses my Mac and creates process
ghosts that prevent me from rebooting my machine.

Using Future.forEach instead kills one process at the time and let the OS handle
it before the next kill.

[Bill Hesse, 2014-10-16 19:30:16]

whesse@google.com changed reviewers:
+ whesse@google.com

[Bill Hesse, 2014-10-16 19:30:17]

lgtm

https://codereview.chromium.org/660823002/diff/1/dart/tools/testing/dart/brow...
File dart/tools/testing/dart/browser_controller.dart (right):

https://codereview.chromium.org/660823002/diff/1/dart/tools/testing/dart/brow...
dart/tools/testing/dart/browser_controller.dart:1236: bool failedToClose =
false;
How about bool success = true, and reverse all the uses of it?

https://codereview.chromium.org/660823002/diff/1/dart/tools/testing/dart/brow...
dart/tools/testing/dart/browser_controller.dart:1240: failedToClose = true;
so: if (!succeeded) { success = false; }

[ahe, 2014-10-20 12:30:58]

Patchset #2 (id:20001) has been deleted

[ahe, 2014-10-20 12:31:38]

Thank you, Bill!

https://codereview.chromium.org/660823002/diff/1/dart/tools/testing/dart/brow...
File dart/tools/testing/dart/browser_controller.dart (right):

https://codereview.chromium.org/660823002/diff/1/dart/tools/testing/dart/brow...
dart/tools/testing/dart/browser_controller.dart:1236: bool failedToClose =
false;
On 2014/10/16 19:30:16, Bill Hesse wrote:
> How about bool success = true, and reverse all the uses of it?

I'll do that, but I'm not sure that I like it better. "success" is generic, and
so I need to add a comment which explains that the variable with the generic
name tracks that close didn't fail.

https://codereview.chromium.org/660823002/diff/1/dart/tools/testing/dart/brow...
dart/tools/testing/dart/browser_controller.dart:1240: failedToClose = true;
On 2014/10/16 19:30:17, Bill Hesse wrote:
> so: if (!succeeded) { success = false; }

Done.

[ahe, 2014-10-20 12:32:57]

Committed patchset #2 (id:40001) manually as 41189 (presubmit successful).