Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 659813002: Apply updates to static methods. (Closed)

Created:
6 years, 2 months ago by ahe
Modified:
6 years, 2 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, kasperl, lukechurch
Visibility:
Public.

Description

Patch Set 1 : #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : Fix types. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -21 lines) Patch
M dart/pkg/dart2js_incremental/lib/diff.dart View 1 2 chunks +12 lines, -3 lines 0 comments Download
M dart/pkg/dart2js_incremental/lib/library_updater.dart View 1 2 6 chunks +84 lines, -16 lines 0 comments Download
M dart/tests/try/web/incremental_compilation_update_test.dart View 2 chunks +67 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ahe
Notice that only one of the new test cases are passing. I started out working ...
6 years, 2 months ago (2014-10-15 15:36:56 UTC) #3
Johnni Winther
lgtm https://codereview.chromium.org/659813002/diff/20001/dart/pkg/dart2js_incremental/lib/diff.dart File dart/pkg/dart2js_incremental/lib/diff.dart (right): https://codereview.chromium.org/659813002/diff/20001/dart/pkg/dart2js_incremental/lib/diff.dart#newcode34 dart/pkg/dart2js_incremental/lib/diff.dart:34: Token token; Add comment on the semantics of ...
6 years, 2 months ago (2014-10-16 07:48:46 UTC) #4
ahe
Thank you, Johnni! https://codereview.chromium.org/659813002/diff/20001/dart/pkg/dart2js_incremental/lib/diff.dart File dart/pkg/dart2js_incremental/lib/diff.dart (right): https://codereview.chromium.org/659813002/diff/20001/dart/pkg/dart2js_incremental/lib/diff.dart#newcode34 dart/pkg/dart2js_incremental/lib/diff.dart:34: Token token; On 2014/10/16 07:48:46, Johnni ...
6 years, 2 months ago (2014-10-16 09:19:48 UTC) #5
ahe
Caught a few type errors during testing in checked mode.
6 years, 2 months ago (2014-10-20 13:24:05 UTC) #6
ahe
6 years, 2 months ago (2014-10-20 15:21:01 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:60001) manually as 41201 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698