Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Issue 659173003: Mark tests flaky on Safari 6.2 (Closed)

Created:
6 years, 1 month ago by Bill Hesse
Modified:
6 years, 1 month ago
Reviewers:
ricow1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Mark tests flaky on Safari 6.2 BUG=dartbug.com/21434 R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=41393

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -8 lines) Patch
M pkg/pkg.status View 1 chunk +6 lines, -5 lines 0 comments Download
M tests/corelib/corelib.status View 1 chunk +3 lines, -1 line 0 comments Download
M tests/html/html.status View 1 1 chunk +6 lines, -1 line 0 comments Download
M tests/lib/lib.status View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Bill Hesse
6 years, 1 month ago (2014-10-29 08:02:11 UTC) #2
ricow1
lgtm https://codereview.chromium.org/659173003/diff/1/tests/html/html.status File tests/html/html.status (right): https://codereview.chromium.org/659173003/diff/1/tests/html/html.status#newcode265 tests/html/html.status:265: wheelevent_test: RuntimeError # Issue 21434. Not flaky! remvove ...
6 years, 1 month ago (2014-10-29 08:04:31 UTC) #3
Bill Hesse
6 years, 1 month ago (2014-10-29 10:30:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 41393 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698