Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 658903005: Reapply "Stop suppressing generation of bindings with Promise. Add some tests for DOM APIs that ans… (Closed)

Created:
6 years, 2 months ago by rmacnak
Modified:
6 years, 2 months ago
Reviewers:
vsm, Leaf
CC:
reviews_dartlang.org, ricow1, terry
Visibility:
Public.

Description

Reapply "Stop suppressing generation of bindings with Promise. Add some tests for DOM APIs that answer promises." Fix static warning in storage_quota_test. Fix status of fontface_loaded_test. R=leafp@google.com Committed: https://code.google.com/p/dart/source/detail?r=41210

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 3

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+735 lines, -17 lines) Patch
M sdk/lib/_blink/dartium/_blink_dartium.dart View 16 chunks +92 lines, -6 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 18 chunks +244 lines, -0 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 18 chunks +202 lines, -0 lines 0 comments Download
A tests/html/fontface_loaded_test.dart View 1 chunk +46 lines, -0 lines 0 comments Download
M tests/html/html.status View 1 2 3 2 chunks +5 lines, -1 line 0 comments Download
A tests/html/storage_quota_test.dart View 1 chunk +38 lines, -0 lines 0 comments Download
M tools/dom/dom.json View 14 chunks +90 lines, -6 lines 0 comments Download
M tools/dom/idl/dart/dart.idl View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/dom/scripts/generator.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 2 3 4 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
rmacnak
https://codereview.chromium.org/658903005/diff/40001/tests/html/html.status File tests/html/html.status (right): https://codereview.chromium.org/658903005/diff/40001/tests/html/html.status#newcode17 tests/html/html.status:17: fontface_loaded_test: Skip # Issue 21359 Should be Pass, Timeout ...
6 years, 2 months ago (2014-10-18 00:15:37 UTC) #2
Leaf
LGTM with one comment. https://codereview.chromium.org/658903005/diff/40001/tests/html/html.status File tests/html/html.status (right): https://codereview.chromium.org/658903005/diff/40001/tests/html/html.status#newcode17 tests/html/html.status:17: fontface_loaded_test: Skip # Issue 21359 ...
6 years, 2 months ago (2014-10-20 17:00:37 UTC) #3
rmacnak
https://codereview.chromium.org/658903005/diff/40001/tests/html/html.status File tests/html/html.status (right): https://codereview.chromium.org/658903005/diff/40001/tests/html/html.status#newcode17 tests/html/html.status:17: fontface_loaded_test: Skip # Issue 21359 On 2014/10/20 17:00:36, leafp ...
6 years, 2 months ago (2014-10-20 18:26:50 UTC) #4
rmacnak
6 years, 2 months ago (2014-10-20 18:27:12 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as 41210 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698