Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 658773002: Fix crash with --trace-deoptimization-verbose and tweak formatting. (Closed)

Created:
6 years, 2 months ago by Florian Schneider
Modified:
6 years, 2 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix crash with --trace-deoptimization-verbose and tweak formatting. Uninitialized instances (e.g. closures) can't be printed using ToCString. Print just the class instead. Print values/addresses consistently with our disassembly output (no leading zeros) This makes searching in the trace output easier. Limit printing source lines to max 80 chars. Otherwise the trace output for minified Dart code gets unreadable. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=41134

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M runtime/vm/deferred_objects.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M runtime/vm/deopt_instructions.cc View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Florian Schneider
6 years, 2 months ago (2014-10-15 14:14:45 UTC) #2
srdjan
lgtm
6 years, 2 months ago (2014-10-15 15:40:47 UTC) #3
Florian Schneider
6 years, 2 months ago (2014-10-15 15:49:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r41134 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698