Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 65843003: Fill in more documentation blanks in dart:io. (Closed)

Created:
7 years, 1 month ago by Andrei Mouravski
Modified:
6 years, 11 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org, Søren Gjesse
Visibility:
Public.

Description

Fill in more documentation blanks in dart:io. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=30115

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated to reference standard IO stream #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M sdk/lib/io/stdio.dart View 1 5 chunks +6 lines, -0 lines 0 comments Download
M sdk/lib/io/string_transformer.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Andrei Mouravski
7 years, 1 month ago (2013-11-08 01:48:28 UTC) #1
floitsch
LGTM. https://codereview.chromium.org/65843003/diff/1/sdk/lib/io/stdio.dart File sdk/lib/io/stdio.dart (right): https://codereview.chromium.org/65843003/diff/1/sdk/lib/io/stdio.dart#newcode174 sdk/lib/io/stdio.dart:174: /// The type of object an IO stream ...
7 years, 1 month ago (2013-11-08 02:20:23 UTC) #2
Andrei Mouravski
Updated and submitting. Thanks!
7 years, 1 month ago (2013-11-08 15:50:54 UTC) #3
Andrei Mouravski
7 years, 1 month ago (2013-11-08 15:51:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r30115 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698