VM: Avoid repeated deoptimization on speculatively hoisted smi-checks.

VM: Avoid repeated deoptimization on speculatively hoisted smi-checks.

This adds the same check as we already have for CheckClass for
CheckSmi and CheckEitherNonSmi instructions to avoid repeated
deoptimization after LICM.

R=srdjan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41133

[Florian Schneider, 2014-10-15 10:37:26]

fschneider@google.com changed reviewers:
+ srdjan@google.com

[srdjan, 2014-10-15 12:56:45]

https://codereview.chromium.org/657613004/diff/1/runtime/vm/intermediate_lang...
File runtime/vm/intermediate_language.h (right):

https://codereview.chromium.org/657613004/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language.h:4593: intptr_t deopt_id) {
initialize licm_hoisted_ to false

https://codereview.chromium.org/657613004/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language.h:7869: : token_pos_(token_pos) {
ditto

[Florian Schneider, 2014-10-15 13:07:34]

https://codereview.chromium.org/657613004/diff/1/runtime/vm/intermediate_lang...
File runtime/vm/intermediate_language.h (right):

https://codereview.chromium.org/657613004/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language.h:4593: intptr_t deopt_id) {
On 2014/10/15 12:56:45, srdjan wrote:
> initialize licm_hoisted_ to false

Done. Good catch.

https://codereview.chromium.org/657613004/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language.h:7869: : token_pos_(token_pos) {
On 2014/10/15 12:56:45, srdjan wrote:
> ditto

Done.

[srdjan, 2014-10-15 15:39:23]

lgtm

[Florian Schneider, 2014-10-15 15:46:56]

Committed patchset #2 (id:20001) manually as r41133 (presubmit successful).