Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 657393002: It's not IE, but chrome that was slow. (Closed)

Created:
6 years, 2 months ago by floitsch
Modified:
6 years, 2 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

It's not IE, but chrome that was slow. Committed: https://code.google.com/p/dart/source/detail?r=41152

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tests/try/try.status View 1 chunk +1 line, -1 line 3 comments Download

Messages

Total messages: 6 (1 generated)
floitsch
TBR.
6 years, 2 months ago (2014-10-16 15:17:04 UTC) #2
floitsch
Committed patchset #1 (id:1) manually as 41152 (presubmit successful).
6 years, 2 months ago (2014-10-16 15:19:01 UTC) #3
ahe
https://codereview.chromium.org/657393002/diff/1/tests/try/try.status File tests/try/try.status (right): https://codereview.chromium.org/657393002/diff/1/tests/try/try.status#newcode34 tests/try/try.status:34: [ $runtime == ff || $runtime == chrome || ...
6 years, 2 months ago (2014-10-16 16:44:34 UTC) #4
ahe
https://codereview.chromium.org/657393002/diff/1/tests/try/try.status File tests/try/try.status (right): https://codereview.chromium.org/657393002/diff/1/tests/try/try.status#newcode34 tests/try/try.status:34: [ $runtime == ff || $runtime == chrome || ...
6 years, 2 months ago (2014-10-16 16:51:37 UTC) #5
floitsch
6 years, 2 months ago (2014-10-16 17:10:15 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/657393002/diff/1/tests/try/try.status
File tests/try/try.status (right):

https://codereview.chromium.org/657393002/diff/1/tests/try/try.status#newcode34
tests/try/try.status:34: [ $runtime == ff || $runtime == chrome || $checked ]
On 2014/10/16 16:51:37, ahe wrote:
> On 2014/10/16 16:44:34, ahe wrote:
> > This is only on Windows, right?
> 
> And it's the compiler, that's timing out:
> 
> Command[dart2js]: ...
> Took 0:01:00.002000
> 
> Command[chrome]: ...
> Did not run

https://codereview.chromium.org/660673003

Powered by Google App Engine
This is Rietveld 408576698