Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 65663002: Default to "127.0.0.1" in pub serve. (Closed)

Created:
7 years, 1 month ago by Bob Nystrom
Modified:
7 years, 1 month ago
Reviewers:
nweiz
CC:
reviews_dartlang.org, Søren Gjesse
Visibility:
Public.

Description

Default to "127.0.0.1" in pub serve. BUG=https://code.google.com/p/dart/issues/detail?id=14677 R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=30128

Patch Set 1 #

Patch Set 2 : Allow IPv6 addresses in plug-in loading. #

Total comments: 2

Patch Set 3 : Revise. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -7 lines) Patch
M sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart View 1 2 3 chunks +8 lines, -7 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/utils.dart View 1 2 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Bob Nystrom
7 years, 1 month ago (2013-11-07 22:48:44 UTC) #1
nweiz
lgtm
7 years, 1 month ago (2013-11-08 00:57:57 UTC) #2
Bob Nystrom
Thanks to Søren, I've got a better patch for this. PTAL.
7 years, 1 month ago (2013-11-08 18:25:21 UTC) #3
nweiz
lgtm https://codereview.chromium.org/65663002/diff/50001/sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart File sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart (right): https://codereview.chromium.org/65663002/diff/50001/sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart#newcode458 sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart:458: hostAndPort += ':${server.port}'; Maybe encapsulate this in a ...
7 years, 1 month ago (2013-11-08 19:35:14 UTC) #4
Bob Nystrom
Thanks! https://codereview.chromium.org/65663002/diff/50001/sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart File sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart (right): https://codereview.chromium.org/65663002/diff/50001/sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart#newcode458 sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart:458: hostAndPort += ':${server.port}'; On 2013/11/08 19:35:14, nweiz wrote: ...
7 years, 1 month ago (2013-11-08 22:35:42 UTC) #5
Bob Nystrom
7 years, 1 month ago (2013-11-08 22:46:49 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r30128 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698