Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 656543003: Split up large resolver_test.dart file. (Closed)

Created:
6 years, 2 months ago by Paul Berry
Modified:
6 years, 2 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Split up large resolver_test.dart file. This splits the four largest classes out of resolver_test.dart and into their own files. Hopefully this should help prevent resolver_test.dart from timing out on the buildbots. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=41085

Patch Set 1 #

Patch Set 2 : Update pkg.status file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12561 lines, -2 lines) Patch
A pkg/analyzer/test/generated/compile_time_error_code_test.dart View 1 1 chunk +4143 lines, -0 lines 0 comments Download
A pkg/analyzer/test/generated/non_error_resolver_test.dart View 1 1 chunk +4269 lines, -0 lines 0 comments Download
A pkg/analyzer/test/generated/static_type_warning_code_test.dart View 1 1 chunk +1326 lines, -0 lines 0 comments Download
A pkg/analyzer/test/generated/static_warning_code_test.dart View 1 1 chunk +2814 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/test_all.dart View 1 2 chunks +9 lines, -1 line 0 comments Download
M pkg/pkg.status View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
Note: the code review tool refused to upload the diff for pkg/analyzer/test/generated/resolver_test.dart due to its ...
6 years, 2 months ago (2014-10-13 21:33:29 UTC) #2
scheglov
LGTM We probably want to structure tests as they were structured in the Java version. ...
6 years, 2 months ago (2014-10-13 21:39:37 UTC) #3
Paul Berry
6 years, 2 months ago (2014-10-13 21:43:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:110001) manually as 41085 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698