Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 656443003: BoundsCheckGeneralizer::Simplify should ignore unsupported binary ops. (Closed)

Created:
6 years, 2 months ago by Vyacheslav Egorov (Google)
Modified:
6 years, 2 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

BoundsCheckGeneralizer::Simplify should ignore unsupported binary ops. R=fschneider@google.com BUG=http://dartbug.com/21324 Committed: https://code.google.com/p/dart/source/detail?r=41118

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M runtime/vm/flow_graph_range_analysis.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Vyacheslav Egorov (Google)
6 years, 2 months ago (2014-10-15 10:18:17 UTC) #1
Florian Schneider
lgtm
6 years, 2 months ago (2014-10-15 10:20:56 UTC) #2
Vyacheslav Egorov (Google)
6 years, 2 months ago (2014-10-15 10:26:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41118 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698