Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issue 65583004: Add utility methods for sending non-form data in pkg/http. (Closed)

Created:
7 years, 1 month ago by nweiz
Modified:
7 years, 1 month ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add utility methods for sending non-form data in pkg/http. R=rnystrom@google.com BUG=8380 Committed: https://code.google.com/p/dart/source/detail?r=30183

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+255 lines, -83 lines) Patch
M pkg/http/lib/http.dart View 1 4 chunks +41 lines, -22 lines 0 comments Download
M pkg/http/lib/src/base_client.dart View 1 3 chunks +54 lines, -23 lines 0 comments Download
M pkg/http/lib/src/client.dart View 1 2 chunks +37 lines, -14 lines 0 comments Download
M pkg/http/test/http_test.dart View 4 chunks +117 lines, -19 lines 0 comments Download
M pkg/http/test/mock_client_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/http/test/utils.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/oauth2/lib/src/authorization_code_grant.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/oauth2/lib/src/credentials.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/command/uploader.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
7 years, 1 month ago (2013-11-11 23:15:33 UTC) #1
Bob Nystrom
One suggestion but otherwise LGTM. Very nice. https://codereview.chromium.org/65583004/diff/1/pkg/http/lib/http.dart File pkg/http/lib/http.dart (right): https://codereview.chromium.org/65583004/diff/1/pkg/http/lib/http.dart#newcode119 pkg/http/lib/http.dart:119: /// If ...
7 years, 1 month ago (2013-11-12 00:07:33 UTC) #2
nweiz
https://codereview.chromium.org/65583004/diff/1/pkg/http/lib/http.dart File pkg/http/lib/http.dart (right): https://codereview.chromium.org/65583004/diff/1/pkg/http/lib/http.dart#newcode119 pkg/http/lib/http.dart:119: /// If [body] is a List, it's used as-is ...
7 years, 1 month ago (2013-11-12 01:59:13 UTC) #3
nweiz
7 years, 1 month ago (2013-11-12 01:59:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r30183 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698