Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(981)

Issue 655803002: Mark analyzer test as failing. (Closed)

Created:
6 years, 2 months ago by floitsch
Modified:
6 years, 2 months ago
Reviewers:
ricow1, Johnni Winther
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Mark analyzer test as failing. Add minimal example to lib/mirrors. R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=41097

Patch Set 1 #

Total comments: 1

Patch Set 2 : Reverted debug code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
M pkg/pkg.status View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +1 line, -0 lines 0 comments Download
A tests/lib/mirrors/get_field_static_test.dart View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
floitsch
6 years, 2 months ago (2014-10-14 12:46:54 UTC) #2
floitsch
https://codereview.chromium.org/655803002/diff/1/sdk/lib/_internal/compiler/implementation/enqueue.dart File sdk/lib/_internal/compiler/implementation/enqueue.dart (right): https://codereview.chromium.org/655803002/diff/1/sdk/lib/_internal/compiler/implementation/enqueue.dart#newcode515 sdk/lib/_internal/compiler/implementation/enqueue.dart:515: if (element.toString().contains("EXPECTED_ONE_LIST_TYPE_ARGUMENTS")) { Debug code. Removing and uploading a ...
6 years, 2 months ago (2014-10-14 12:47:32 UTC) #3
ricow1
lgtm
6 years, 2 months ago (2014-10-14 12:49:53 UTC) #5
floitsch
6 years, 2 months ago (2014-10-14 13:44:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 41097 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698