Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1550)

Issue 655703004: Fix analyzer error in pub's generated source. (Closed)

Created:
6 years, 2 months ago by Bill Hesse
Modified:
6 years, 2 months ago
Reviewers:
ricow1, nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix analyzer error in pub's generated source. BUG=https://github.com/dart-lang/async_await/issues/68 R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=41126

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M sdk/lib/_internal/pub/lib/src/entrypoint.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub_generated/lib/src/entrypoint.dart View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Bill Hesse
Identical to the change in https://codereview.chromium.org//655943002 , applied in a second location.
6 years, 2 months ago (2014-10-15 12:02:45 UTC) #2
Bill Hesse
On 2014/10/15 12:02:45, Bill Hesse wrote: > Identical to the change in https://codereview.chromium.org//655943002 > > ...
6 years, 2 months ago (2014-10-15 12:04:16 UTC) #3
ricow1
lgtm
6 years, 2 months ago (2014-10-15 12:16:33 UTC) #4
Bill Hesse
Committed patchset #1 (id:1) manually as 41126 (presubmit successful).
6 years, 2 months ago (2014-10-15 12:47:45 UTC) #5
Bill Hesse
6 years, 2 months ago (2014-10-15 13:05:29 UTC) #6
Message was sent while issue was closed.
On 2014/10/15 12:04:16, Bill Hesse wrote:
> On 2014/10/15 12:02:45, Bill Hesse wrote:
> > Identical to the change in https://codereview.chromium.org//655943002
> > 
> > , applied in a second location.
> 
> This works around the issue
https://github.com/dart-lang/async_await/issues/68,
> but the issue is already solved, and could also be applied by updating the
> checkout of async-await in dart/third_party/pkg/async-await.

Oops - the issue is not fixed in tip-of-tree async-await.

Powered by Google App Engine
This is Rietveld 408576698