Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 654653007: Change update_homebrew script to work with single-file homebrew formulas. (Closed)

Created:
6 years, 2 months ago by Bill Hesse
Modified:
6 years, 2 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Change update_homebrew script to work with single-file homebrew formulas. BUG= R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=41125

Patch Set 1 #

Patch Set 2 : Remove unused function. #

Total comments: 4

Patch Set 3 : Address comments #

Patch Set 4 : Fix long line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -21 lines) Patch
M tools/apps/update_homebrew/bin/update_homebrew.dart View 1 2 3 2 chunks +166 lines, -21 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Bill Hesse
6 years, 2 months ago (2014-10-14 13:58:34 UTC) #2
Bill Hesse
ping
6 years, 2 months ago (2014-10-15 09:26:26 UTC) #3
ricow1
lgtm https://codereview.chromium.org/654653007/diff/20001/tools/apps/update_homebrew/bin/update_homebrew.dart File tools/apps/update_homebrew/bin/update_homebrew.dart (right): https://codereview.chromium.org/654653007/diff/20001/tools/apps/update_homebrew/bin/update_homebrew.dart#newcode20 tools/apps/update_homebrew/bin/update_homebrew.dart:20: final SDK_FILES = [ 'sdk/dartsdk-macos-x64-release.zip', remove space before ...
6 years, 2 months ago (2014-10-15 11:30:41 UTC) #4
Bill Hesse
https://codereview.chromium.org/654653007/diff/20001/tools/apps/update_homebrew/bin/update_homebrew.dart File tools/apps/update_homebrew/bin/update_homebrew.dart (right): https://codereview.chromium.org/654653007/diff/20001/tools/apps/update_homebrew/bin/update_homebrew.dart#newcode20 tools/apps/update_homebrew/bin/update_homebrew.dart:20: final SDK_FILES = [ 'sdk/dartsdk-macos-x64-release.zip', On 2014/10/15 11:30:41, ricow1 ...
6 years, 2 months ago (2014-10-15 12:45:47 UTC) #5
Bill Hesse
6 years, 2 months ago (2014-10-15 12:46:05 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as 41125 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698