Handle top-level tear offs.

Handle top-level tear offs.

R=johnniwinther@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41130

[ahe, 2014-10-13 13:36:18]

Patchset #1 (id:1) has been deleted

[ahe, 2014-10-13 13:37:15]

Patchset #1 (id:40001) has been deleted

[ahe, 2014-10-13 13:38:26]

Patchset #1 (id:70001) has been deleted

[ahe, 2014-10-13 13:40:19]

Patchset #1 (id:110001) has been deleted

[ahe, 2014-10-13 13:41:41]

ahe@google.com changed reviewers:
+ johnniwinther@google.com

[Johnni Winther, 2014-10-14 07:40:26]

lgtm

https://codereview.chromium.org/654523003/diff/150001/dart/pkg/dart2js_increm...
File dart/pkg/dart2js_incremental/lib/library_updater.dart (right):

https://codereview.chromium.org/654523003/diff/150001/dart/pkg/dart2js_increm...
dart/pkg/dart2js_incremental/lib/library_updater.dart:236: throw '$element
${element.runtimeType}';
internalError instead of throw?

https://codereview.chromium.org/654523003/diff/150001/dart/tests/try/web/incr...
File dart/tests/try/web/incremental_compilation_update_test.dart (right):

https://codereview.chromium.org/654523003/diff/150001/dart/tests/try/web/incr...
dart/tests/try/web/incremental_compilation_update_test.dart:59: // Test that a
store closure changes behavior when updated.
store -> stored

[ahe, 2014-10-15 09:11:12]

Thank you, Johnni!

https://codereview.chromium.org/654523003/diff/150001/dart/pkg/dart2js_increm...
File dart/pkg/dart2js_incremental/lib/library_updater.dart (right):

https://codereview.chromium.org/654523003/diff/150001/dart/pkg/dart2js_increm...
dart/pkg/dart2js_incremental/lib/library_updater.dart:236: throw '$element
${element.runtimeType}';
On 2014/10/14 07:40:26, Johnni Winther wrote:
> internalError instead of throw?

Good idea, I hadn't thought about this as part of the compiler, but it is.

https://codereview.chromium.org/654523003/diff/150001/dart/tests/try/web/incr...
File dart/tests/try/web/incremental_compilation_update_test.dart (right):

https://codereview.chromium.org/654523003/diff/150001/dart/tests/try/web/incr...
dart/tests/try/web/incremental_compilation_update_test.dart:59: // Test that a
store closure changes behavior when updated.
On 2014/10/14 07:40:26, Johnni Winther wrote:
> store -> stored

Done.

[ahe, 2014-10-15 10:42:05]

FYI, new patch set.

https://codereview.chromium.org/654523003/diff/240001/dart/tests/try/try.status
File dart/tests/try/try.status (right):

https://codereview.chromium.org/654523003/diff/240001/dart/tests/try/try.stat...
dart/tests/try/try.status:16: web/incremental_compilation_update_test: Skip #
Safari may crash on this test.
I have to skip this test on Safari. The browser crashes and auto-reloads the
page which in turn crashes test.dart (reported as
https://code.google.com/p/dart/issues/detail?id=21334).

[ahe, 2014-10-15 13:49:41]

Committed patchset #4 (id:240001) manually as 41130 (presubmit successful).