Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Issue 652833005: Add additional check to vmservice/websocket_client test. (Closed)

Created:
6 years, 2 months ago by Bill Hesse
Modified:
6 years, 2 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Add additional check to vmservice/websocket_client test. Fix type errors in update_homebrew script. BUG= R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=41166

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M tests/standalone/vmservice/websocket_client_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/apps/update_homebrew/bin/update_homebrew.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Bill Hesse
6 years, 2 months ago (2014-10-17 10:37:40 UTC) #2
kustermann
LGTM
6 years, 2 months ago (2014-10-17 11:07:23 UTC) #3
Bill Hesse
6 years, 2 months ago (2014-10-17 12:11:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41166 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698