Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 652833002: Fix constant evaluation in the presence of nonexistent fields. (Closed)

Created:
6 years, 2 months ago by Paul Berry
Modified:
6 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix constant evaluation in the presence of nonexistent fields. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=41082

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -6 lines) Patch
M pkg/analyzer/lib/src/generated/constant.dart View 1 chunk +8 lines, -6 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 1 chunk +12 lines, -0 lines 0 comments Download
A tests/language/compile_time_constant13_test.dart View 1 chunk +27 lines, -0 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
Paul Berry
6 years, 2 months ago (2014-10-13 20:33:21 UTC) #2
Brian Wilkerson
LGTM https://codereview.chromium.org/652833002/diff/1/tests/language/compile_time_constant13_test.dart File tests/language/compile_time_constant13_test.dart (right): https://codereview.chromium.org/652833002/diff/1/tests/language/compile_time_constant13_test.dart#newcode13 tests/language/compile_time_constant13_test.dart:13: : x = 'foo' /// 01: continued Why ...
6 years, 2 months ago (2014-10-13 20:54:56 UTC) #3
Paul Berry
https://codereview.chromium.org/652833002/diff/1/tests/language/compile_time_constant13_test.dart File tests/language/compile_time_constant13_test.dart (right): https://codereview.chromium.org/652833002/diff/1/tests/language/compile_time_constant13_test.dart#newcode13 tests/language/compile_time_constant13_test.dart:13: : x = 'foo' /// 01: continued On 2014/10/13 ...
6 years, 2 months ago (2014-10-13 21:04:34 UTC) #4
Paul Berry
6 years, 2 months ago (2014-10-13 21:07:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41082 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698