Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 652743007: - Do not attempt to set parameter types if they (Closed)

Created:
6 years, 2 months ago by Ivan Posva
Modified:
6 years, 2 months ago
Reviewers:
zra, Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

- Do not attempt to set parameter types if they were already finalized. R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=41182

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M runtime/vm/class_finalizer.cc View 1 chunk +9 lines, -4 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Ivan Posva
6 years, 2 months ago (2014-10-17 21:44:15 UTC) #2
zra
lgtm
6 years, 2 months ago (2014-10-17 21:50:00 UTC) #4
Ivan Posva
6 years, 2 months ago (2014-10-17 21:50:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r41182 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698