Issue 652723002: Add support for source maps in deferred libraries.

Issue 652723002: Add support for source maps in deferred libraries. (Closed)

Created:
6 years, 2 months ago by floitsch

Modified:
6 years, 2 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org, sigurdm

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add support for source maps in deferred libraries. BUG= http://dartbug.com/21221 R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=41094 Reverted: https://code.google.com/p/dart/source/detail?r=41095 Committed: https://code.google.com/p/dart/source/detail?r=41103

Patch Set 2 : Address comment. #

Patch Set 3 : Rebase after revert. #

Patch Set 4 : Guard against null-uris. #

Total comments: 1

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -34 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/emitter.dart	View	1 2 3	3 chunks	+38 lines, -15 lines	1 comment	Download
A +	tests/compiler/dart2js/source_map_deferred_d2js_validity_test.dart	View		1 chunk	+10 lines, -6 lines	0 comments	Download
A +	tests/compiler/dart2js/source_map_deferred_validator_test_file.dart	View		1 chunk	+8 lines, -5 lines	0 comments	Download
A +	tests/compiler/dart2js/source_map_deferred_validator_test_lib.dart	View		1 chunk	+5 lines, -8 lines	0 comments	Download
M	tests/compiler/dart2js/source_map_validator_test_file.dart	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Johnni Winther

lgtm https://codereview.chromium.org/652723002/diff/1/sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/emitter.dart File sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/emitter.dart (right): https://codereview.chromium.org/652723002/diff/1/sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/emitter.dart#newcode1915 sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/emitter.dart:1915: deferredPartFileName(outputUnit, addExtension: false), 'part.js') Store `deferredPartFileName(...)` is local ...

6 years, 2 months ago (2014-10-14 07:46:41 UTC) #3

floitsch

https://codereview.chromium.org/652723002/diff/1/sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/emitter.dart File sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/emitter.dart (right): https://codereview.chromium.org/652723002/diff/1/sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/emitter.dart#newcode1915 sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/emitter.dart:1915: deferredPartFileName(outputUnit, addExtension: false), 'part.js') On 2014/10/14 07:46:41, Johnni Winther ...

6 years, 2 months ago (2014-10-14 09:34:06 UTC) #4

floitsch

Committed patchset #2 (id:90001) manually as 41094 (presubmit successful).

6 years, 2 months ago (2014-10-14 09:34:36 UTC) #5

floitsch

Added guards against null-values. PTAL, but I'm going to submit now. Will do follow-up CLs ...

6 years, 2 months ago (2014-10-14 16:53:23 UTC) #6

floitsch

Committed patchset #4 (id:130001) manually as 41103 (presubmit successful).

6 years, 2 months ago (2014-10-14 16:53:46 UTC) #7

Johnni Winther

6 years, 2 months ago (2014-10-15 07:27:45 UTC) #8

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/652723002/diff/130001/sdk/lib/_internal/compi...
File
sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/emitter.dart
(right):

https://codereview.chromium.org/652723002/diff/130001/sdk/lib/_internal/compi...
sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/emitter.dart:1895:
if (generateSourceMap) {
We should make [generateSourceMap] conditional on `sourceMapUri != null` and
`outputUri != null`.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages