Add tree shaker support for setters and field writes.

Add tree shaker support for setters and field writes.

R=scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41229

[Paul Berry, 2014-10-21 14:20:47]

paulberry@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2014-10-21 14:58:21]

LGTM

https://codereview.chromium.org/652613004/diff/1/pkg/analyzer2dart/lib/src/tr...
File pkg/analyzer2dart/lib/src/tree_shaker.dart (right):

https://codereview.chromium.org/652613004/diff/1/pkg/analyzer2dart/lib/src/tr...
pkg/analyzer2dart/lib/src/tree_shaker.dart:143: if (accessor.isSetter &&
'${selector.name}=' == accessor.name) {
We could probably make it slightly faster by computing '${selector.name}='
outside of the loop.

https://codereview.chromium.org/652613004/diff/1/pkg/analyzer2dart/test/tree_...
File pkg/analyzer2dart/test/tree_shaker_test.dart (right):

https://codereview.chromium.org/652613004/diff/1/pkg/analyzer2dart/test/tree_...
pkg/analyzer2dart/test/tree_shaker_test.dart:401: // Strip off the '=' to avoid
confusion in writing the tests.
We could use element.displayName instead.

[Paul Berry, 2014-10-21 15:14:04]

https://codereview.chromium.org/652613004/diff/1/pkg/analyzer2dart/lib/src/tr...
File pkg/analyzer2dart/lib/src/tree_shaker.dart (right):

https://codereview.chromium.org/652613004/diff/1/pkg/analyzer2dart/lib/src/tr...
pkg/analyzer2dart/lib/src/tree_shaker.dart:143: if (accessor.isSetter &&
'${selector.name}=' == accessor.name) {
On 2014/10/21 14:58:21, scheglov wrote:
> We could probably make it slightly faster by computing '${selector.name}='
> outside of the loop.

Done.

https://codereview.chromium.org/652613004/diff/1/pkg/analyzer2dart/test/tree_...
File pkg/analyzer2dart/test/tree_shaker_test.dart (right):

https://codereview.chromium.org/652613004/diff/1/pkg/analyzer2dart/test/tree_...
pkg/analyzer2dart/test/tree_shaker_test.dart:401: // Strip off the '=' to avoid
confusion in writing the tests.
On 2014/10/21 14:58:21, scheglov wrote:
> We could use element.displayName instead.

Done.

[Paul Berry, 2014-10-21 15:17:11]

Committed patchset #1 (id:1) manually as 41229 (presubmit successful).

[Johnni Winther, 2014-10-22 13:21:16]

johnniwinther@google.com changed reviewers:
+ johnniwinther@google.com

[Johnni Winther, 2014-10-22 13:21:16]

lgtm