Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 652583003: Mark test as flaky on Safari (Closed)

Created:
6 years, 2 months ago by ahe
Modified:
6 years, 2 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M dart/tests/try/try.status View 1 chunk +3 lines, -0 lines 3 comments Download

Messages

Total messages: 6 (1 generated)
ahe
6 years, 2 months ago (2014-10-13 12:09:24 UTC) #2
ricow1
lgtm https://codereview.chromium.org/652583003/diff/1/dart/tests/try/try.status File dart/tests/try/try.status (right): https://codereview.chromium.org/652583003/diff/1/dart/tests/try/try.status#newcode22 dart/tests/try/try.status:22: web/source_update_test: Fail, Pass # Safari is flaky, suspect ...
6 years, 2 months ago (2014-10-13 12:10:17 UTC) #3
ahe
Thank you, Rico. https://codereview.chromium.org/652583003/diff/1/dart/tests/try/try.status File dart/tests/try/try.status (right): https://codereview.chromium.org/652583003/diff/1/dart/tests/try/try.status#newcode22 dart/tests/try/try.status:22: web/source_update_test: Fail, Pass # Safari is ...
6 years, 2 months ago (2014-10-13 12:39:38 UTC) #4
ahe
Committed patchset #1 (id:1) manually as 41071 (presubmit successful).
6 years, 2 months ago (2014-10-13 12:40:13 UTC) #5
ahe
6 years, 2 months ago (2014-10-13 12:52:15 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/652583003/diff/1/dart/tests/try/try.status
File dart/tests/try/try.status (right):

https://codereview.chromium.org/652583003/diff/1/dart/tests/try/try.status#ne...
dart/tests/try/try.status:22: web/source_update_test: Fail, Pass # Safari is
flaky, suspect bad optimization.
On 2014/10/13 12:39:38, ahe wrote:
> On 2014/10/13 12:10:17, ricow1 wrote:
> > did you file a bug with apple?
> 
> No, but I've submitted feedback on Safari including this link:
> https://drive.google.com/file/d/0BwSI1YSEb713R2xxY2YzR2JaS0E/view?usp=sharing
> 
> I'm not really impressed with Apple when it comes to reporting a bug. After I
> hit submit, the page froze, and I'm not sure my feedback was submitted.

Feedback submitted on second attempt. I hit the X in the location bar and hit
the submit button again.

Powered by Google App Engine
This is Rietveld 408576698