Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Issue 651953005: Disable test "check_all_test" on debug builds. (Closed)

Created:
6 years, 2 months ago by Paul Berry
Modified:
6 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Disable test "check_all_test" on debug builds. The only purpose of this test is to verify that analysis server code generation is up to date, so it is sufficient to just run it on the release buildbots, where is completes more quickly. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=41086

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M pkg/pkg.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
6 years, 2 months ago (2014-10-13 21:40:36 UTC) #2
Brian Wilkerson
LGTM
6 years, 2 months ago (2014-10-13 21:44:06 UTC) #3
Paul Berry
6 years, 2 months ago (2014-10-13 21:49:55 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41086 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698