Issue 651823002: Rewrite csslib's hexToInt

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 651823002: Rewrite csslib's hexToInt (Closed)

Created:
6 years, 2 months ago by srawlins

Modified:
6 years, 2 months ago

Reviewers:
terry

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

I was looking at the typo in 19178, and then the TODO in hexToInt. int.parse gained its radix parameter in https://code.google.com/p/dart/issues/detail?id=2624 around Dart SDK v1.1, so I bumped it in the pubspec. Rewrite csslib's hexToInt BUG= https://code.google.com/p/dart/issues/detail?id=19178 R=terry@google.com Committed: https://code.google.com/p/dart/source/detail?r=41079

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -29 lines)			Patch
	M	pkg/csslib/lib/src/property.dart	View		1 chunk	+1 line, -28 lines	0 comments	Download
	M	pkg/csslib/pubspec.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

srawlins

Hi Terry, I ended up completing a TODO you had in csslib while looking to ...

6 years, 2 months ago (2014-10-13 06:06:04 UTC) #2

srawlins

6 years, 2 months ago (2014-10-13 18:00:39 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 41079 (presubmit successful).