Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Issue 651013002: Reuse function objects of async closure body (Closed)

Created:
6 years, 2 months ago by hausner
Modified:
6 years, 2 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Reuse function objects of async closure body When an async function is compiled, it creates a closure that contains the code of the async function’s body. Before this change, a new function object is created each time the async function is compiled. This change looks up previously created closures and reuses them, similar to what the parser does for local functions. R=rmacnak@google.com Committed: https://code.google.com/p/dart/source/detail?r=41084

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -29 lines) Patch
M runtime/vm/parser.cc View 1 3 chunks +51 lines, -29 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
hausner
6 years, 2 months ago (2014-10-13 20:43:01 UTC) #2
rmacnak
LGTM
6 years, 2 months ago (2014-10-13 21:33:15 UTC) #3
hausner
6 years, 2 months ago (2014-10-13 21:38:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:60001) manually as r41084 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698