Use a re-usable buffer for writing HTTP headers. This includes a new header limit of 8192 bytes.

Use a re-usable buffer for writing HTTP headers. This includes a new header limit of 8192 bytes.

BUG=
R=sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30335

[Søren Gjesse, 2013-11-18 10:06:37]

lgtm

https://codereview.chromium.org/65043019/diff/1/sdk/lib/io/http_headers.dart
File sdk/lib/io/http_headers.dart (right):

https://codereview.chromium.org/65043019/diff/1/sdk/lib/io/http_headers.dart#...
sdk/lib/io/http_headers.dart:356: final COLONSP = const [_CharCode.COLON,
_CharCode.SP];
Not related to this change, but are these variables actually used?

https://codereview.chromium.org/65043019/diff/1/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/65043019/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:803: writeSP();
Maybe inline this

  buffer[offset++] = _CharCode.SP;

[Anders Johnsen, 2013-11-18 10:27:28]

https://codereview.chromium.org/65043019/diff/1/sdk/lib/io/http_headers.dart
File sdk/lib/io/http_headers.dart (right):

https://codereview.chromium.org/65043019/diff/1/sdk/lib/io/http_headers.dart#...
sdk/lib/io/http_headers.dart:356: final COLONSP = const [_CharCode.COLON,
_CharCode.SP];
On 2013/11/18 10:06:38, Søren Gjesse wrote:
> Not related to this change, but are these variables actually used?

Done.

https://codereview.chromium.org/65043019/diff/1/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/65043019/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:803: writeSP();
On 2013/11/18 10:06:38, Søren Gjesse wrote:
> Maybe inline this
> 
>   buffer[offset++] = _CharCode.SP;
> 

Done.

[Anders Johnsen, 2013-11-18 10:28:01]

Committed patchset #2 manually as r30335 (presubmit successful).