Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 650323003: Allow analyzer to distinguish unresolved types from dynamic. (Closed)

Created:
6 years, 2 months ago by Paul Berry
Modified:
6 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Allow analyzer to distinguish unresolved types from dynamic. This makes it possible to correctly report checked mode compile time errors in the event of unresolved typenames. BUG=dartbug.com/16391 R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=41098

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -19 lines) Patch
M pkg/analyzer/lib/src/generated/constant.dart View 5 chunks +18 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element.dart View 7 chunks +82 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 11 chunks +26 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 11 chunks +120 lines, -1 line 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
6 years, 2 months ago (2014-10-14 00:38:34 UTC) #2
Brian Wilkerson
LGTM
6 years, 2 months ago (2014-10-14 13:21:06 UTC) #3
Paul Berry
6 years, 2 months ago (2014-10-14 13:47:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41098 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698