Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 649873007: Remove Math and most uses of PrintStringWriter (Closed)

Created:
6 years, 1 month ago by Brian Wilkerson
Modified:
6 years, 1 month ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove Math and most uses of PrintStringWriter R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=41318

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -165 lines) Patch
M pkg/analysis_server/lib/src/services/generated/completion.dart View 3 chunks +6 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/services/generated/util.dart View 14 chunks +42 lines, -39 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 3 chunks +15 lines, -14 lines 0 comments Download
M pkg/analyzer/lib/src/generated/java_core.dart View 2 chunks +4 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 4 chunks +11 lines, -9 lines 0 comments Download
M pkg/analyzer/lib/src/generated/scanner.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/utilities_collection.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/all_the_rest.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 3 chunks +61 lines, -61 lines 0 comments Download
M pkg/analyzer/test/generated/test_support.dart View 9 chunks +26 lines, -21 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
6 years, 1 month ago (2014-10-26 23:35:28 UTC) #2
scheglov
LGTM
6 years, 1 month ago (2014-10-27 03:38:56 UTC) #3
Brian Wilkerson
6 years, 1 month ago (2014-10-27 14:49:29 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41318 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698