Issue 649743002: - Fine grain locking of free list when sweeping concurrently.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 649743002: - Fine grain locking of free list when sweeping concurrently. (Closed)

Created:
6 years, 2 months ago by Ivan Posva

Modified:
6 years, 2 months ago

Reviewers:
koda

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Fine grain locking of free list when sweeping concurrently. Committed: https://code.google.com/p/dart/source/detail?r=41049

Patch Set 1 #

Total comments: 2

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -10 lines)			Patch
M	runtime/vm/gc_sweeper.h	View	1 chunk	+1 line, -1 line	2 comments	Download
M	runtime/vm/gc_sweeper.cc	View	3 chunks	+7 lines, -7 lines	0 comments	Download
M	runtime/vm/pages.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

koda

LGTMwC https://codereview.chromium.org/649743002/diff/1/runtime/vm/gc_sweeper.h File runtime/vm/gc_sweeper.h (right): https://codereview.chromium.org/649743002/diff/1/runtime/vm/gc_sweeper.h#newcode27 runtime/vm/gc_sweeper.h:27: // all the unmarked objects to the pre-locked ...

6 years, 2 months ago (2014-10-10 18:38:02 UTC) #3

Ivan Posva

Committed patchset #1 (id:1) manually as r41049 (presubmit successful).

6 years, 2 months ago (2014-10-10 19:44:44 UTC) #4

Ivan Posva

6 years, 2 months ago (2014-10-10 20:47:42 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/649743002/diff/1/runtime/vm/gc_sweeper.h
File runtime/vm/gc_sweeper.h (right):

https://codereview.chromium.org/649743002/diff/1/runtime/vm/gc_sweeper.h#newc...
runtime/vm/gc_sweeper.h:27: // all the unmarked objects to the pre-locked
freelist.
On 2014/10/10 18:38:01, koda wrote:
> Update comment.
> 
> Also clarify that when page is unused, freelist is not touched.

Done.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages