Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 649733002: Check field type when evaluating initializing formals. (Closed)

Created:
6 years, 2 months ago by Paul Berry
Modified:
6 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Check field type when evaluating initializing formals. This performs proper type checking when the type of a field differs from the type of a field formal parameter, e.g.: class A { final T1 x; const A(T2 this.x); } // only works if <expr> is a subtype of both T1 and T2. var a = const A(<expr>); Previously we only checked the parameter type (T2 in the above example). BUG=dartbug.com/16391 R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=41048

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -4 lines) Patch
M pkg/analyzer/lib/src/generated/constant.dart View 1 chunk +14 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/element.dart View 1 chunk +7 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 1 chunk +14 lines, -0 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
6 years, 2 months ago (2014-10-10 18:20:22 UTC) #2
Brian Wilkerson
LGTM
6 years, 2 months ago (2014-10-10 18:32:17 UTC) #3
Paul Berry
6 years, 2 months ago (2014-10-10 18:50:24 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41048 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698