Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 648883002: Add more options to configure the linter. (Closed)

Created:
6 years, 2 months ago by Siggi Cherem (dart-lang)
Modified:
6 years, 2 months ago
Reviewers:
jakemac
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add more options to configure the linter. R=jakemac@google.com Committed: https://code.google.com/p/dart/source/detail?r=41077

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -18 lines) Patch
M pkg/polymer/lib/builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/lib/deploy.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/polymer/lib/src/build/common.dart View 1 2 3 chunks +38 lines, -3 lines 0 comments Download
M pkg/polymer/lib/src/build/linter.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/polymer/lib/transformer.dart View 3 chunks +40 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Siggi Cherem (dart-lang)
6 years, 2 months ago (2014-10-10 23:29:37 UTC) #2
jakemac
lgtm
6 years, 2 months ago (2014-10-13 14:33:26 UTC) #3
jakemac
https://codereview.chromium.org/648883002/diff/90001/pkg/polymer/lib/src/build/common.dart File pkg/polymer/lib/src/build/common.dart (right): https://codereview.chromium.org/648883002/diff/90001/pkg/polymer/lib/src/build/common.dart#newcode170 pkg/polymer/lib/src/build/common.dart:170: if (patterns == null) return true; this should probably ...
6 years, 2 months ago (2014-10-13 14:35:19 UTC) #4
Siggi Cherem (dart-lang)
thx https://codereview.chromium.org/648883002/diff/90001/pkg/polymer/lib/src/build/common.dart File pkg/polymer/lib/src/build/common.dart (right): https://codereview.chromium.org/648883002/diff/90001/pkg/polymer/lib/src/build/common.dart#newcode170 pkg/polymer/lib/src/build/common.dart:170: if (patterns == null) return true; On 2014/10/13 ...
6 years, 2 months ago (2014-10-13 16:09:33 UTC) #5
Siggi Cherem (dart-lang)
6 years, 2 months ago (2014-10-13 16:09:55 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:160001) manually as 41077 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698