Issue 648473002: Add unit test for freeing VirtualMemory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 648473002: Add unit test for freeing VirtualMemory. (Closed)

Created:
6 years, 2 months ago by koda

Modified:
6 years, 2 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add unit test for freeing VirtualMemory. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=41043

Patch Set 3 : #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -0 lines)			Patch
	M	runtime/vm/virtual_memory_test.cc	View	1 2	1 chunk	+37 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM -ip https://codereview.chromium.org/648473002/diff/30001/runtime/vm/virtual_memory_test.cc File runtime/vm/virtual_memory_test.cc (right): https://codereview.chromium.org/648473002/diff/30001/runtime/vm/virtual_memory_test.cc#newcode49 runtime/vm/virtual_memory_test.cc:49: vm->Commit(false); You might want to alternate the ...

6 years, 2 months ago (2014-10-09 18:31:56 UTC) #2

koda

On 2014/10/09 18:31:56, Ivan Posva wrote: > LGTM -ip > > https://codereview.chromium.org/648473002/diff/30001/runtime/vm/virtual_memory_test.cc > File runtime/vm/virtual_memory_test.cc ...

6 years, 2 months ago (2014-10-10 15:40:53 UTC) #3

koda

6 years, 2 months ago (2014-10-10 15:41:02 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:80001) manually as r41043 (presubmit successful).

Expand Messages | Collapse Messages

Issue 648473002: Add unit test for freeing VirtualMemory. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages