Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 64793003: Update mirror tests for removed API. (Closed)

Created:
7 years, 1 month ago by rmacnak
Modified:
7 years, 1 month ago
Reviewers:
ahe, gbracha
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Update mirror tests for removed API and other analyzer warnings. BUG=http://dartbug.com/14695 R=gbracha@google.com Committed: https://code.google.com/p/dart/source/detail?r=30290

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : whitespace #

Total comments: 4

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+400 lines, -305 lines) Patch
M runtime/tests/vm/dart/mirrored_compilation_error_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/message_kind_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/lib/lib.status View 1 2 3 4 5 6 7 5 chunks +4 lines, -47 lines 0 comments Download
M tests/lib/mirrors/basic_types_in_dart_core_test.dart View 1 chunk +10 lines, -10 lines 0 comments Download
M tests/lib/mirrors/constructor_kinds_test.dart View 3 chunks +10 lines, -9 lines 0 comments Download
M tests/lib/mirrors/constructors_test.dart View 2 chunks +12 lines, -4 lines 0 comments Download
M tests/lib/mirrors/equality_test.dart View 1 2 3 2 chunks +22 lines, -22 lines 0 comments Download
M tests/lib/mirrors/fake_function_with_call_test.dart View 2 chunks +11 lines, -2 lines 0 comments Download
M tests/lib/mirrors/field_type_test.dart View 1 2 3 4 3 chunks +12 lines, -11 lines 0 comments Download
M tests/lib/mirrors/generic_function_typedef_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/lib/mirrors/generic_type_mirror_test.dart View 1 2 3 2 chunks +14 lines, -14 lines 0 comments Download
M tests/lib/mirrors/generics_substitution_test.dart View 1 chunk +6 lines, -3 lines 0 comments Download
M tests/lib/mirrors/generics_test.dart View 1 chunk +4 lines, -5 lines 0 comments Download
M tests/lib/mirrors/hierarchy_invariants_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/lib/mirrors/immutable_collections_test.dart View 2 chunks +12 lines, -24 lines 0 comments Download
M tests/lib/mirrors/inherit_field_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/lib/mirrors/initializing_formals_test.dart View 1 2 10 chunks +21 lines, -10 lines 0 comments Download
M tests/lib/mirrors/intercepted_class_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/lib/mirrors/lazy_static_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/mirrors/libraries_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/mirrors/library_metadata2_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/lib/mirrors/metadata_constructed_constant_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/mirrors/metadata_test.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M tests/lib/mirrors/method_mirror_properties_test.dart View 1 chunk +12 lines, -12 lines 0 comments Download
M tests/lib/mirrors/method_mirror_returntype_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/mirrors/method_mirror_source_test.dart View 1 chunk +10 lines, -10 lines 0 comments Download
M tests/lib/mirrors/mirrors_test.dart View 2 chunks +6 lines, -6 lines 0 comments Download
M tests/lib/mirrors/mixin_application_test.dart View 14 chunks +43 lines, -26 lines 0 comments Download
M tests/lib/mirrors/mixin_members_test.dart View 1 chunk +13 lines, -4 lines 0 comments Download
M tests/lib/mirrors/operator_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/lib/mirrors/parameter_metadata_test.dart View 1 2 1 chunk +21 lines, -13 lines 0 comments Download
M tests/lib/mirrors/parameter_test.dart View 4 chunks +11 lines, -8 lines 0 comments Download
M tests/lib/mirrors/private_symbol_test.dart View 2 chunks +7 lines, -7 lines 0 comments Download
M tests/lib/mirrors/reflect_class_test.dart View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M tests/lib/mirrors/reflect_model_test.dart View 4 chunks +44 lines, -12 lines 0 comments Download
M tests/lib/mirrors/reflect_runtime_type_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M tests/lib/mirrors/reflect_uninstantiated_class_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M tests/lib/mirrors/regress_14304_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A tests/lib/mirrors/removed_api_test.dart View 1 chunk +37 lines, -0 lines 0 comments Download
M tests/lib/mirrors/return_type_test.dart View 2 chunks +9 lines, -3 lines 0 comments Download
M tests/lib/mirrors/static_test.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M tests/lib/mirrors/to_string_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M tests/lib/mirrors/type_variable_owner_test.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
rmacnak
The mirror tests, the whole mirror tests, and nothing but the mirror tests. :(
7 years, 1 month ago (2013-11-08 18:26:21 UTC) #1
gbracha
lgtm except for two missing casts. https://codereview.chromium.org/64793003/diff/80001/tests/lib/mirrors/equality_test.dart File tests/lib/mirrors/equality_test.dart (right): https://codereview.chromium.org/64793003/diff/80001/tests/lib/mirrors/equality_test.dart#newcode139 tests/lib/mirrors/equality_test.dart:139: : thisLibrary.declarations[#somePredicate].type}, /// ...
7 years, 1 month ago (2013-11-08 18:55:13 UTC) #2
rmacnak
https://codereview.chromium.org/64793003/diff/80001/tests/lib/mirrors/equality_test.dart File tests/lib/mirrors/equality_test.dart (right): https://codereview.chromium.org/64793003/diff/80001/tests/lib/mirrors/equality_test.dart#newcode139 tests/lib/mirrors/equality_test.dart:139: : thisLibrary.declarations[#somePredicate].type}, /// 02: ok On 2013/11/08 18:55:13, gbracha ...
7 years, 1 month ago (2013-11-14 00:49:07 UTC) #3
rmacnak
Synced. Looks like those analyzer bugs got fixed.
7 years, 1 month ago (2013-11-14 01:08:19 UTC) #4
gbracha
On 2013/11/14 01:08:19, Ryan Macnak wrote: > Synced. Looks like those analyzer bugs got fixed. ...
7 years, 1 month ago (2013-11-14 19:31:53 UTC) #5
rmacnak
7 years, 1 month ago (2013-11-14 19:55:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #8 manually as r30290 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698