Test that analysis server and analysis engine enums properly match.

Test that analysis server and analysis engine enums properly match.

R=brianwilkerson@google.com, scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41029

[Paul Berry, 2014-10-09 21:14:32]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[Paul Berry, 2014-10-09 21:14:33]

Brian and Konstantin,

I'm concerned with the number of exceptions I found while writing these tests
(see TODO comments in protocol_server_test.dart).  I'm interested in your
opinion as to whether any of these exceptions are bugs, or whether they are all
purposeful differences between the enums.

[Brian Wilkerson, 2014-10-09 21:41:22]

https://codereview.chromium.org/647563002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/protocol.dart (right):

https://codereview.chromium.org/647563002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/protocol.dart:231: abstract class Enum {
I can't think of a better name, but I am mildly concerned that we now have at
least two Enum classes.

https://codereview.chromium.org/647563002/diff/1/pkg/analysis_server/test/pro...
File pkg/analysis_server/test/protocol_server_test.dart (right):

https://codereview.chromium.org/647563002/diff/1/pkg/analysis_server/test/pro...
pkg/analysis_server/test/protocol_server_test.dart:483: // TODO(paulberry): do
any of the exceptions below constitute bugs?
Yes. Some of these can almost certainly get passed to the client. The angular
and polymer specific ones, for example. Those were excluded from the list in the
specification because we intend to eventually have those be generated by
plugins. (I won't go into what plugin support means in this case.) I'm not sure
what we want to do short-term in those cases.

Others exist on the server side but currently cannot be passed to the client,
such as "IMPORT", "EXPORT", and UNIVERSE.

Some of them I'm not even sure what they're used for on the server side, such as
"ERROR" or "NAME" (although I have a guess about the latter).

https://codereview.chromium.org/647563002/diff/1/pkg/analysis_server/test/pro...
pkg/analysis_server/test/protocol_server_test.dart:513: // TODO(paulberry): do
any of the exceptions below constitute bugs?
I think these also fall into the "they should be defined by a plugin" case.

[scheglov, 2014-10-09 21:44:16]

https://codereview.chromium.org/647563002/diff/1/pkg/analysis_server/test/pro...
File pkg/analysis_server/test/protocol_server_test.dart (right):

https://codereview.chromium.org/647563002/diff/1/pkg/analysis_server/test/pro...
pkg/analysis_server/test/protocol_server_test.dart:483: // TODO(paulberry): do
any of the exceptions below constitute bugs?
All these ElementKind values represent features that are not supported for the
server because we wait for plugins, or are used internally.

https://codereview.chromium.org/647563002/diff/1/pkg/analysis_server/test/pro...
pkg/analysis_server/test/protocol_server_test.dart:509: // use SearchResultKind
inside the analysis server?
We could, but it is kind of mixing layers here.
SearchEngine is an internal mechanism, one part of which is exposed as
SearchResult, but it provides information for other, internal, layers of the
server, such as refactoring.

[Brian Wilkerson, 2014-10-09 21:47:08]

LGTM

[scheglov, 2014-10-09 21:48:55]

LGTM

[Paul Berry, 2014-10-09 21:53:10]

Committed patchset #1 (id:1) manually as 41029 (presubmit successful).