Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 647553006: Fix for missing LineInfo to SDK entries. (Closed)

Created:
6 years, 2 months ago by scheglov
Modified:
5 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix for missing LineInfo to SDK entries. I will update analyzer reference in pubspec before commit. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41064

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -9 lines) Patch
M pkg/analysis_server/pubspec.yaml View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/notification_navigation_test.dart View 1 chunk +13 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 2 chunks +15 lines, -7 lines 0 comments Download
M pkg/analyzer/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 2 months ago (2014-10-11 21:56:57 UTC) #1
Brian Wilkerson
Good find! LGTM.
6 years, 2 months ago (2014-10-12 20:22:52 UTC) #2
scheglov
6 years, 2 months ago (2014-10-12 21:27:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41064 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698