Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 647523002: Uses correct mnemonic for vmrs instructions. (Closed)

Created:
6 years, 2 months ago by zra
Modified:
6 years, 2 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Uses correct mnemonic for vmrs instructions. Keeps vmstat as a macro. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=41042

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -13 lines) Patch
M runtime/vm/assembler_arm.h View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/assembler_arm.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M runtime/vm/constants_arm.h View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/disassembler_arm.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M runtime/vm/simulator_arm.cc View 1 1 chunk +15 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
zra
6 years, 2 months ago (2014-10-09 19:47:54 UTC) #2
Ivan Posva
LGTM -ip
6 years, 2 months ago (2014-10-10 05:28:47 UTC) #3
zra
6 years, 2 months ago (2014-10-10 15:30:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:70001) manually as r41042.

Powered by Google App Engine
This is Rietveld 408576698